search

stylelint / stylelint-demo

The online demo on the Stylelint website
https://stylelint.io/demo/
MIT License
15 stars 8 forks source link

Bump monaco-editor from 0.43.0 to 0.45.0 #382

Closed dependabot[bot] closed 11 months ago

dependabot[bot] commented 1 year ago

Bumps monaco-editor from 0.43.0 to 0.44.0.

Changelog

Sourced from monaco-editor's changelog.

[0.44.0]

  • Removes old diff editor implementation.
  • Custom diff algorithms no longer can be passed via diff editor options, instead a service should be used ([see #3558 for more details](microsoft/monaco-editor#3558)).

[0.42.0]

  • Uses new diff editor widget by default. Use experimental.useVersion2: false to use the old widget. The old widget will be replaced in the next update.
  • Diff editor uses inline mode by default when width is too small. Use the config option useInlineViewWhenSpaceIsLimited to control this behavior.
  • Fixes broken language features when a model is created before the editor.

[0.41.0]

  • IDiffEditor.diffReviewNext was renamed to IDiffEditor.accessibleDiffViewerNext.
  • IDiffEditor.diffReviewPrev was renamed to IDiffEditor.accessibleDiffViewerPrev.
  • Introduces InlineCompletionsProvider.yieldsToGroupIds to allows inline completion providers to yield to other providers.
  • Bugfixes

Contributions to monaco-editor:

[0.40.0]

  • Support for Glyph Margin Widgets
  • Removes getDiffLineInformationForOriginal and getDiffLineInformationForModified from IDiffEditor
  • createTrustedTypesPolicy is optional now
  • New option IModelDecorationOptions.shouldFillLineOnLineBreak
  • New option EditorOptions.readOnlyMessage

[0.39.0]

  • New method Environment.createTrustedTypesPolicy to override trusted types handling.
  • Bugfixes

Contributions to monaco-editor:

... (truncated)

Commits
  • 3e047ef Fixes node-gyp issues
  • e409ac0 Adds node-gyp as dev dependency
  • 93957fa Merge pull request #4202 from microsoft/dependabot/npm_and_yarn/webpack-plugi...
  • 8665a71 Merge pull request #4203 from microsoft/dependabot/npm_and_yarn/samples/postc...
  • cfdfe21 Bump electron from 19.1.8 to 22.3.25 in /samples (#4205)
  • 6354c35 Bump postcss from 8.4.16 to 8.4.31 in /samples
  • 105e132 Bump postcss from 8.4.12 to 8.4.31 in /webpack-plugin
  • 2e82147 Removes outdated sample
  • f015a01 Fixes CI
  • 7e3d25a Preparing for v0.44.0
  • See full diff in compare view


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

netlify[bot] commented 1 year ago

Deploy Preview for chimerical-trifle-8d3c21 ready!

Name Link
Latest commit 41e35145fdcfc363e3c749c0f9a4933247402f4f
Latest deploy log https://app.netlify.com/sites/chimerical-trifle-8d3c21/deploys/6573c48a537d1f0008b3650d
Deploy Preview https://deploy-preview-382--chimerical-trifle-8d3c21.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ybiquitous commented 1 year ago

@dependabot rebase

ybiquitous commented 1 year ago

Diff highlighting is not working: 👀

Production This PR
image image
ybiquitous commented 1 year ago

@dependabot rebase

ybiquitous commented 1 year ago

I'm looking into this problem but cannot find a reason. 😢 Apparently, v0.43.0 and v0.44.0 has different behavior for Diff Editor.

v0.43.0

The split view is displayed.

image

https://microsoft.github.io/monaco-editor/playground.html?source=v0.43.0#example-creating-the-diffeditor-hello-diff-world

v0.44.0

The inline view is displayed:

image

https://microsoft.github.io/monaco-editor/playground.html?source=v0.44.0#example-creating-the-diffeditor-hello-diff-world

ybiquitous commented 1 year ago

@ota-meshi If you have any ideas, please let us know. 🙏🏼

ota-meshi commented 1 year ago

The diff editor has been significantly redesigned. useInlineViewWhenSpaceIsLimited: false is required for previous behavior.

I still don't know why highlighting isn't working :thinking:

ota-meshi commented 1 year ago

Looks like a bug in monaco 🤔 If we remove one linebreak, the difference highlighting works properly.

https://deploy-preview-382--chimerical-trifle-8d3c21.netlify.app/#N4Igxg9gJgpiBcICGACYAdAdugLgcwCcBLKAWhxgFsAHAGyQtKQJiQGd4tdcByVJHlxy8ARijEieAbiGRaBeCgAWbegAoATAAYANCgCMWgKR6AzMb0BWIwEoZmAL5dMqDDlKkAYhAiL9LSnsnTBAdEAAzIloYADkkSjhEGAAPeLoYADowNjZQ8AhMSLwEEAxMFBR0EBSKTCg2KsUAbSwKiqq2HABPaNoiTHdIQqI8Uk6kOuYoKtaUAF0sBzyhou8CSgYSgCs2ArzYalzEMvaQTp6YPoHGypB6Ck6qnVmO7t7+wYKisZwJqCmblV7jBHiBFiAHEA

vapkse commented 1 year ago

Great. Thanks a lot!

I believe we may be able to merge this PR now, but we can also wait for a new fixed version of monaco-editor (despite the bug of diff highlighting) because this bug is not critical.

I'll leave that decision up to you. 👌🏼

Good morning. For me, the highlighting bug is critical, it breaks the editor and once the error occurs, it's impossible to use the editor correctly except reload the models, which loses the selection. I have to rollback to the 43.

ota-meshi commented 11 months ago

Highlighting seems to work correctly when using monaco-editor v0.45. So I'll merge this PR.

image
ybiquitous commented 11 months ago

@ota-meshi Nice! Thank you.