search

stylelint / stylelint-demo

The online demo on the Stylelint website
https://stylelint.io/demo/
MIT License
15 stars 8 forks source link

Fix background color on dark mode #416

Closed ybiquitous closed 3 months ago

ybiquitous commented 3 months ago

Which issue, if any, is this issue related to?

Follow-up to #413

Is there anything in the PR that needs further explanation?

I came across this issue on the dark mode supported by the demo site (https://stylelint.io/demo).

To reproduce it locally, edit src/demo.css like this:

    /* Sectioning root */
    body {
+       background-color: black;
        color: var(--sd-black);
netlify[bot] commented 3 months ago

Deploy Preview for chimerical-trifle-8d3c21 ready!

Name Link
Latest commit 844e0def535e685cc8caea82f26042cb6f9c2478
Latest deploy log https://app.netlify.com/sites/chimerical-trifle-8d3c21/deploys/66ab904a2ab1470008af9e0b
Deploy Preview https://deploy-preview-416--chimerical-trifle-8d3c21.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ybiquitous commented 3 months ago

Here's another way to reproduce this issue locally with https://github.com/stylelint/stylelint.io:

  1. Check out stylelint.io
  2. Edit src/pages/demo.js using this preview URL like this: 
    -        const FRAME_ORIGIN = 'https://chimerical-trifle-8d3c21.netlify.app';
+        const FRAME_ORIGIN = 'https://deploy-preview-416--chimerical-trifle-8d3c21.netlify.app';
  3. Run npm ci && npm start
  4. Go to http://localhost:3000/demo
ybiquitous commented 3 months ago

@jeddy3 Does this PR change make sense? I'd be happy if you could take a quick look. 🙏🏼

jeddy3 commented 3 months ago

LGTM. Explicitly setting the background colour is fine.