search

stylelint / stylelint-ecosystem-tester

A comprehensive test suite for Stylelint ecosystem.
MIT License
0 stars 0 forks source link

Disable failing packages for now #39

Closed romainmenke closed 1 month ago

romainmenke commented 2 months ago

As mentioned in https://github.com/stylelint/stylelint-ecosystem-tester/pull/24, scheduled GitHub workflows ping the last editor of that workflow each time a run fails.

So my inbox each day looks like this 😅

Screenshot 2024-08-19 at 10 41 11

The purpose of this repo is to find new and unexpected failures when we make changes in Stylelint itself.

Packages that are already failing arguably are not that interesting to track.

I propose that we comment out each failing package in ecosystem.yml. While simultaneously opening a pull request for each to uncomment it again.

Each time such a PR turns green we can merge it.

ybiquitous commented 2 months ago

Oh, I agree with disabling them... Sorry for bothering you 🙇🏼

Please feel free to do it! 🙏🏼

romainmenke commented 1 month ago

Thank you @ybiquitous 🙇

Let's see how this approach goes. I will try to prepare pull requests for each failing package and link those to upstream PR's or issues.

Mouvedia commented 1 month ago

@wordpress/stylelint-config has a new release.

ybiquitous commented 1 month ago

Great. Can you open a PR to reenable it? If it passes CI, let's merge it!