styler00dollar / VapourSynth-RIFE-ncnn-Vulkan

RIFE filter for VapourSynth
MIT License
113 stars 22 forks source link

Artifacts with models 25+, model or support issue? #60

Open Selur opened 3 weeks ago

Selur commented 3 weeks ago

Models: 69 = rife-v4.25 (ensemble=False) 70 = rife-v4.25-lite (ensemble=False) 71 = rife-v4.25-heavy (ensemble=False) 72 = rife-v4.26 (ensemble=False) all cause artifacts: grafik which the previous models did not create grafik So I was wondering it this the models themselves or is something broken with their support?

TNTwise commented 3 weeks ago

does this happen at all resolutions?, im not getting such artifacts on my end. Does it happen with this version? https://github.com/styler00dollar/VapourSynth-RIFE-ncnn-Vulkan/releases/tag/r9_mod_v27 I modified some code and that may have played a part in it.

Selur commented 3 weeks ago

Yes, it also happens with v27. (side note: 4.25+ work fine in vs-rife and vs-mlrt, so it's not a general problem of the model) My source: https://drive.google.com/file/d/1xchtRU6uZyLm9xJWh4HgNxDrSqC70zhl/view?usp=drive_link It does not happen if I resize the source beforehand to 1280x704 (good catch), so it seems to be resolution dependent. :) (works with both v27 and v30 if I resize beforhand)

TNTwise commented 3 weeks ago

What resolution does it artifact at? Nvm I see on the source, thank you. This is an issue because of the new scaling in rife, I don't think it's a conversion issue, but an issue within the vs rife ncnn code.

Selur commented 3 weeks ago

640x352: fails (= artifacts) 1280x704: works (= no artifacts) 720x396: fails 960x528: fails 1024x564: works