search

stylesplugin / styles

Change colors and fonts in WordPress themes using the built-in theme customizer.
http://stylesplugin.com
17 stars 9 forks source link

Text Control: Combine with color picker #5

Open pdclark opened 11 years ago

westonruter commented 11 years ago

Also, as prototyped in #19, allow specification of units other than px

pdclark commented 11 years ago

@westonruter: Moved your comment about units to a new issue, #23.

Also, OMG, when I saw this issue referenced in your pull request, I thought you had resolved it and got SO excited. The reason I haven't done this already is that the Color Picker javascript that connects Iris to the Customizer instance is uncommented, abstracted, and shorthanded. I can't make heads or tails of it. :/ I need to talk to Matt from Automattic's Team Custom about it. (I think he wrote it).

For the curious, here is where I think the Color Control is connected to the Customizer: customize-controls.js#788 and where the colorPicker is instantiated: customize-controls#125.

It's easy to instantiate Iris on any input element, but for some reason, if you set up an input that works with Customizer, then instantiate Iris on it, no update or save events appear to fire with the input is modified by Iris. :(

pdclark commented 11 years ago

I contacted Matt. He's sending me his slides on how advanced parts of the Customizer API work. Also, yes, I did have to assign myself an issue to force myself to socialize.