stylewarning / hypergeometrica

Livin' like it's 1813 (or 1988).
BSD 3-Clause "New" or "Revised" License
30 stars 6 forks source link

add SB-POSIX to ASD dependencies #38

Closed paulapatience closed 1 year ago

paulapatience commented 1 year ago

Also guarded the SBCL dependencies behind the SBCL feature, as is done further below in the ASD file (though there remain various unguarded calls to SBCL packages throughout the source code), and removed the comment beside the SB-MPFR dependency, because it is used in more than just tests (in MPD-PI via MPD-RECIPROCAL).

stylewarning commented 1 year ago

I believe these dependencies can be guarded with specific ASDF syntax. Something like this.

stylewarning commented 1 year ago

(Side note: honestly, I should probably cordon off the TEST-PI into the test package where MPFR is expected. The main package isn't the right place I don't think. Just laziness on my part.)

paulapatience commented 1 year ago

I believe these dependencies can be guarded with specific ASDF syntax. Something like this.

I knew about :if-feature, but not about :feature for :depends-on. Thanks.

I've force-pushed the PR with :feature :sbcl instead of #+sbcl.

stylewarning commented 1 year ago

Thanks!