search

stylianosnicoletti / dotnet-certificate-tool

Command line tool to install and remove certificates from the current user's store.
https://www.nuget.org/packages/dotnet-certificate-tool
Apache License 2.0
109 stars 28 forks source link

Make the password parameter optional to support *.cer and *.crt. #9

Closed pierre3 closed 4 years ago

pierre3 commented 4 years ago

6

  1. When give a .cer or .crt in the input than don't ask for a -p (password) as a mandatory inout parameter

I fixed it because I needed it too.

yohanb commented 4 years ago

merged! I'll publish the new version soon.

ekwus commented 4 years ago

Hey thanks for adding this feature and the app in general.

I'm also thinking that the passwordKeyPath needs to be made optional too but maybe I've missed something? The use case is when you are using the tool to add a custom/private root certificate. You generally don't have access to the private key and/or don't want to use it out with the CA.

I'm working on a fix for this and can turn it in to a pull request if it would be useful?

Cheers

Dave

yohanb commented 4 years ago

Hi @ekwus! My pleasure. Yeah go for it, pull requests are more than welcome! :) Yohan