Open styliii opened 9 years ago
Hmm, check this out https://github.com/styliii/Styliii-Twitter-Client/tree/master/app/src/main/java/com/codepath/apps. I don't see the actual source code. Could you try committing again so the source code is available.
Once you post that up, happy to help you catch any issues with persistence.
@styliii Also can you pls submit a new GIF once you have resolved the issues? Current GIF shows timeline for a while and only crashes after that.
oh, i think you're right that it's rate limiting. ok let me fix the repo.
On Mon, Mar 9, 2015 at 10:17 PM CodePath Reviewers notifications@github.com wrote:
@styliii https://github.com/styliii Also can you pls submit a new GIF once you have resolved the issues? Current GIF shows timeline for a while and only crashes after that.
— Reply to this email directly or view it on GitHub https://github.com/styliii/Styliii-Twitter-Client/issues/1#issuecomment-77997382 .
i think i screwed everything up using VCS under Android Studio. Which directory do I choose for the Github repo? The main one right?
Can you go into your github repo and do the following on the command line:
rm -rf .git/
git init
git add .
git commit -m "initial commit"
git remote add origin <github repo>
git push origin master --force
and avoid the android studio git integration.
ok done
I don't see any activities except login... https://github.com/styliii/Styliii-Twitter-Client/tree/master/app/src/main/java/com/styliii/twitterlogin
are there activities missing?
i don't understand....i have 3 activities, two adapters, 2 models, that it's not showing up. 1 second.
nevermind, i was pushing up the wrong stuff. 2 seconds!
pushed up now. i had put in some network connectivity stuff, but pulled it out thinking it didn't work. in retrospect, it was probably because of the API rate limit.
:+1: Congrats on completing the third project! Nice work overall. Good job on implementing all the required stories and implementing a few optionals, the UI looks clean as well.
I have provided a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together.
Didn't have enough time to do a good job. Will continue to add on though. /cc @codepath @codepathreview
Also, i put in some persistence, but it's not working quite right. Not sure if the query is working correctly, or if i'm calling it wrong in ActivityTimeline