styliii / Styliii-Twitter-Client

twitter look a like on android
1 stars 0 forks source link

[Android Bootcamp] Assignment 3: Simple Twitter Client #1

Open styliii opened 9 years ago

styliii commented 9 years ago

Didn't have enough time to do a good job. Will continue to add on though. /cc @codepath @codepathreview

Also, i put in some persistence, but it's not working quite right. Not sure if the query is working correctly, or if i'm calling it wrong in ActivityTimeline

nesquena commented 9 years ago

Hmm, check this out https://github.com/styliii/Styliii-Twitter-Client/tree/master/app/src/main/java/com/codepath/apps. I don't see the actual source code. Could you try committing again so the source code is available.

nesquena commented 9 years ago

Once you post that up, happy to help you catch any issues with persistence.

codepathreview commented 9 years ago

@styliii Also can you pls submit a new GIF once you have resolved the issues? Current GIF shows timeline for a while and only crashes after that.

styliii commented 9 years ago

oh, i think you're right that it's rate limiting. ok let me fix the repo.

On Mon, Mar 9, 2015 at 10:17 PM CodePath Reviewers notifications@github.com wrote:

@styliii https://github.com/styliii Also can you pls submit a new GIF once you have resolved the issues? Current GIF shows timeline for a while and only crashes after that.

— Reply to this email directly or view it on GitHub https://github.com/styliii/Styliii-Twitter-Client/issues/1#issuecomment-77997382 .

styliii commented 9 years ago

i think i screwed everything up using VCS under Android Studio. Which directory do I choose for the Github repo? The main one right?

screen shot 2015-03-09 at 10 42 05 pm

nesquena commented 9 years ago

Can you go into your github repo and do the following on the command line:

rm -rf .git/
git init
git add .
git commit -m "initial commit"
git remote add origin <github repo>
git push origin master --force

and avoid the android studio git integration.

styliii commented 9 years ago

ok done

nesquena commented 9 years ago

I don't see any activities except login... https://github.com/styliii/Styliii-Twitter-Client/tree/master/app/src/main/java/com/styliii/twitterlogin

nesquena commented 9 years ago

are there activities missing?

styliii commented 9 years ago

i don't understand....i have 3 activities, two adapters, 2 models, that it's not showing up. 1 second.

styliii commented 9 years ago

nevermind, i was pushing up the wrong stuff. 2 seconds!

styliii commented 9 years ago

pushed up now. i had put in some network connectivity stuff, but pulled it out thinking it didn't work. in retrospect, it was probably because of the API rate limit.

codepathreview commented 9 years ago

:+1: Congrats on completing the third project! Nice work overall. Good job on implementing all the required stories and implementing a few optionals, the UI looks clean as well.

I have provided a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together.