[Android Bootcamp] Assignment 3: Twitter with Fragments

styliii commented 9 years ago

/cc @codepath @codepathreview

My app is ready to review. I have all the requirements, and a couple extras. Will continue to work on it from here though.

Can I get some help on how to refactor? The Mentions, User and and Home Timeline fragments all were extended from TweetsListFragment, but i couldn't figure out how to attach the onScrollListener without duplicating code.

nesquena commented 9 years ago

Can I get some help on how to refactor? The Mentions, User and and Home Timeline fragments all were extended from TweetsListFragment, but i couldn't figure out how to attach the onScrollListener without duplicating code.

Take a look at sample gist and read tip #2. Let me know if you need any other details around how to approach this.

Full review coming later.

codepathreview commented 9 years ago

:+1: Project looks good. Good job implementing the required stories, the UI looks clean but can be improved more.

Nice job with including progress circle.
Good use of view holder pattern inside adapter
Good to see you properly communicated the user to the user timeline fragment from the profile activity.
Nice to see you used the ViewPager to properly setup the tabs!
Good to see you played with styling a bit
Nice use of tag to setup the ability to click the profile image and view a user's profile
Architecting the fragments (base class and extension classes) should be done such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ, you have a lot of code duplication. Let me know if you need more help to understand this even after following the gist and tip posted above.
Try to implement more optional features so that you will get to play with more widgets and understand complexities involved

I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr using the same patterns.

styliii commented 9 years ago

Thanks for the tip on refactoring @nesquena. Should have known it was in the helpful tips section! I refactored and will continue working on this.

styliii / Styliii-Twitter-Client

[Android Bootcamp] Assignment 3: Twitter with Fragments #2