extensions.stylish.updatesEnabled is not honored

[kirill9000]

I set this pref to false, but Stylish is still making requests to https://update.userstyles.org/xxxxxx.md5 periodically. Please fix it.

[yfdyh000]

Works for me with Firefox 43, Stylish 2.0.4.

[kirill9000]

I've encountered this issue with 2.0.2. Re-tested just now with 2.0.4 and it still happens.

[yfdyh000]

Could you reproduce it with an clean profile?

[kirill9000]

Yes.

STR: 1) Create a new profile. 2) Install Stylish from AMO. 3) Enable Browser Toolbox in Developer Tools' options. 4) Restart the browser. 5) Install random style from userstyles.org. 6) Set extensions.stylish.updatesEnabled to false in about:config. 7) Open Browser Toolbox on the Network tab and start waiting. 8) After some time there is a request to https://update.userstyles.org/xxxxxx.md5

[yfdyh000]

I can't reproduce this experience.

[kirill9000]

I used Firefox 43, official Linux x86_64 build from Mozilla's FTP. But it shouldn't matter, I think. Just followed the same steps again - reproduces perfectly. Waiting interval from step 7 to step 8 was ~10 minutes.

Did you use Browser Toolboxes Network tab to monitor requests? Standard Developer Tools' Network tab doesn't display behind-the-scene requests (i.e. from browser itself & addons).

[yfdyh000]

Okay, I reproduce it now, the needs waiting time longer than I expected. The checks does not appear to be an automatic add-ons updates check, at least it cannot be the Add-ons Manager - Tools menu to trigger.

p.s. the Browser Console - Networks works for this case, just need enabled the Net - Log filter.

[yfdyh000]

@kirill9000 Can you verify its validity?

[kirill9000]

@yfdyh000 I've applied your patch, but unfortunately it didn't help.

[yfdyh000]

@kirill9000 Can you verify it again? Thanks.

[kirill9000]

@yfdyh000 Tried again with no luck. Actually I even tried return false there - still doesn't work. Some other code path is responsible.

[Gitoffthelawn]

Any update on this?