[firefox] about:addons interface breagake in 1.3.2

[msva]

Hi! After upgrading to 1.3.2 I discovered that Stylish changes about:addons look without any permission. It minifies "enable"/"disable"/"preferences"/"remove" buttons in addons list, it also uglify dropdown-menu button with update options, and it also make some more ugly-looking thing in about:addons. For example, brake radiobuttons and checkboxes in such way, that it is no difference between checked and unchecked ones (but that part of bug was even in 1.3.1).

Firstly, I noticed this thing on FT DeepDark skin, but then, after some checking, I discovered, that this behaviour affects all skins, and, looks like, that behaviour can't be turned off.

Disabling stylish at all - fixes all that situations. So, it seems, it is some mistakes in CSSes, installed by Stylish.

[JasonBarnabe]

Nothing changed in 1.3.2 that should affect this.

Is there a problem in the default theme?

[msva]

Yes, it changes about:addons look even in default theme. And, it wasn't change buttons in 1.3.1, before the update, so, that's why I talking about 1.3.2 bug. And, as I already said, it was brake radiobuttons and checkboxes even in 1.3.1 (and, maybe even earlier. Need to be checked, I guess)   23.04.2013, 04:25, "Jason Barnabe" notifications@github.com:Nothing changed in 1.3.2 that should affect this.Is there a problem in the default theme?—Reply to this email directly or view it on GitHub.

[LouCypher]

Doesn't happen to me on Win XP Firefox 20, 21, 22, 17.0.5, Seamonkey 2.17, Pale Moon 20, Thunderbird 17.0.5 Theme: default

@msva If you click Stylish icon and select Turn all styles off menu does the issue still occur?

[msva]

Yes, both things occurs even after "disable all styles". And both disappears when Stylish is disabled.

Doesn't happen to me on Win XP Firefox 20, 21, 22, 17.0.5, Seamonkey 2.17, Pale Moon 20, Thunderbird 17.0.5 Theme: default

@msva https://github.com/msva If you click Stylish icon and select /Turn all styles off/ menu does the issue still occur?

— Reply to this email directly or view it on GitHub https://github.com/JasonBarnabe/stylish/issues/95#issuecomment-16850998.

[JasonBarnabe]

Can you post a screenshot of the problem?

Also, can you try downgrading to 1.3.1 to make sure that it's the new version that's the problem? https://addons.mozilla.org/en-US/firefox/addon/stylish/versions/

[msva]

1) will you accept screenshots wit FT DeepDark, or I should only show differences in default theme? 2) buttons-related bug disappeared after downgrade to 1.3.1, but checkboxes/radiobuttons-related - exists even there.

23.04.2013 23:49, Jason Barnabe пишет:

Can you post a screenshot of the problem?

Also, can you try downgrading to 1.3.1 to make sure that it's the new version that's the problem? https://addons.mozilla.org/en-US/firefox/addon/stylish/versions/

— Reply to this email directly or view it on GitHub https://github.com/JasonBarnabe/stylish/issues/95#issuecomment-16870809.

[JasonBarnabe]

With the default theme would be better.

[msva]

UPD for prev comment: not exactly "even there": with 1.3.2 it appears for many addons settings dialogs, including, for example RequestPolicy and Tab Mix Plus. with 1.3.1 it appears for Tab Mix Plus, but do not - for Request Policy.

Disabling stylish still fixes problem. P.S.: Talking about "under FT DeepDark theme".

And, yes. Will make some screenshots now, but default theme looks ugly itself with my dark system colour scheme and "oxygen-gtk" enabled.

But I hope, you'll be able to detect difference. Wait few minutes, I'll make screenshots now.

[msva]

So, Default theme, stylish disabled:

Default theme, stylish enabled:

DeepDark theme, stylish disabled

Deepdark theme, stylish enabled

[msva]

and, what about radiobuttons: Request policy, stylish enabled: Request policy, stylish disabled:

[msva]

anybody alive here? :)

[JasonBarnabe]

Sorry, don't know what's going on. I don't have a Mac to test with and I can't think of any change from 1.3.1 to 1.3.2 that affects how this would work.

[msva]

[some field news] I just downloaded Stylish from here, truncated stylish-firefox/skin/extensions-gnome.css to be empty and both bugs disappeared.

So, I'll investigate which thing in the CSS causes that and inform you.

[msva]

LOL. Some more fun field news: [fixed] manually downloaded stylish even from addons.mozilla.org — works like a charm. But when I reinstall it directly from firefox by press "add to firefox" — i get that bug... I really don't know whats the hellish magic is it. So, I'll investigate some more.

[msva]

So, I really can't understand that magic: .xpi, which Firefox install itself is identical to that one, that I download via cURL and install manually. Files there is identical to files in that repo. But somewhy bug appears only and only when Stylish is installed via "add to Firefox". Moreover, icons-and buttons related bug appears only and only in 1.3.2, and radiobuttons one — in 1.3.1 too.

I can only guess about something like some kind of policies or something like that.

[JasonBarnabe]

Whatever this was, it doesn't sound like a problem on my end.

[msva]

btw. JFYI: I found same issue with new ESB addon release: https://github.com/kustodian/extended-statusbar/issues/35#issuecomment-58635801

As far, as I looked in it's commit history, it is somehow related to Fx's initial loading of CSSes. So, I bet it was either Fx bug about CSS prioritization or just was accidentally fixed here, when you fixed something else ;)