search

stylus / nib

Stylus mixins, utilities, components, and gradient image generation
http://stylus.github.io/nib
MIT License
1.9k stars 250 forks source link

Mixin for text stroke #160

Closed iam4x closed 10 years ago

iam4x commented 11 years ago

Just added a new mixin for creating stroke using text-shadow property.

notslang commented 11 years ago

this is kinda already done by the text-stroke property, right? http://css-tricks.com/adding-stroke-to-web-text/

iam4x commented 10 years ago

Hmm this is kinda old now.

But text-stroke is still only working on recent webkit, the text-shadow is supported by most of the browsers.

notslang commented 10 years ago

hmm... can we make this into a reliable fallback and add some tests? Then I'd love to merge this.

iam4x commented 10 years ago

Okey, let's try to close and merge this. I added tests, what do we still need?

notslang commented 10 years ago

The only thing that worries me is that you can't use the regular text-stroke property with this... It can't function as a fallback. That's not to say we can't merge it anyway; it's just not ideal.

iam4x commented 10 years ago

I understand, maybe it will be more meaningfull to call this shadow-stroke ?

And if you want to use the normal property, with prefix -webkit is your choice I think.

notslang commented 10 years ago

shadow-stroke would be a good name

iam4x commented 10 years ago

Good to merge?

notslang commented 10 years ago

yep, thanks @iam4x!

incompl commented 10 years ago

I can't get this to work. Is it not merged properly?

notslang commented 10 years ago

just released 1.0.3... now try

incompl commented 10 years ago

Looks like an update is just what I needed, thanks!