search

stylus / nib

Stylus mixins, utilities, components, and gradient image generation
http://stylus.github.io/nib
MIT License
1.91k stars 249 forks source link

add normalize support #235

Closed cyberglot closed 8 years ago

cyberglot commented 10 years ago

This PR adds support to Nicolas Gallagher's Normalize v2.1.3, using the same conventions as the reset one.

nsonnad commented 10 years ago

+1 for this change, using nib seems like it'd be the best way to include normalize as an optional module in a given project. (And reset can be a bit heavy-handed).

Semigradsky commented 9 years ago

Ping?

notslang commented 9 years ago

this should have tests, the docs should be included in https://github.com/visionmedia/nib/tree/master/docs, and normalize should be upgraded to 3.0.2. But other than that, :+1: from me :smile:

cyberglot commented 9 years ago

Well, It was updated a year ago when I opened the PR :smile: but I can do it, no problem. The PR for docs are at #236.

Does reset have tests? I couldn't find them.

notslang commented 9 years ago

Thanks!

We just need some basic tests... like put all the resets in a file, compile it, and then save that as the expected output.

Oh, and I'm moving the docs into the master branch itself because we've had a problem with keeping them updated while they're in a separate branch. So now you can include the updates to the docs right in this PR.

ghost commented 9 years ago

Ping :bell: . What's the status on this? I have been working and curating my port in nrmlz including tests, but have succumbed to the lures of nib and decided to incorporate it into my workflow for new projects. I think however it is essential to have Gallagher's Normalize integrated here.