search

stylus / nib

Stylus mixins, utilities, components, and gradient image generation
http://stylus.github.io/nib
MIT License
1.91k stars 249 forks source link

Inherit & initial value support for opacity #252

Closed leny closed 10 years ago

leny commented 10 years ago

Hi,

When we give the initial or inherit keyword value to opacity in nib, it throws an error.

I was thinking that was an error in all the vendor-replacement code, so I had tests to verify the behavior of all the vendor properties with initialor inherit value. ;)

leny commented 10 years ago

@slang800 ?

I'm working on a plugin to polyfill the initial keyword, but my unit tests are failing with nib because of this issue. :(

leny commented 10 years ago

Any though on this PR ?

I've proposed two months ago, and I don't understand why I have no response on this. It's a small fix, I've added tests... I don't know what to do to have a little feedback here. :(

notslang commented 10 years ago

Sorry, I should have looked at this much earlier - excellent PR @leny!

leny commented 10 years ago

Thanks for the merge. Probably the PR was shy and hiding under the carpet :smile: