search

stylus / nib

Stylus mixins, utilities, components, and gradient image generation
http://stylus.github.io/nib
MIT License
1.91k stars 249 forks source link

Why is iconic in this repo? #282

Open jescalan opened 9 years ago

jescalan commented 9 years ago

It seems like it was randomly dropped in, and hasn't been touched since the initial commit...

notslang commented 9 years ago

ref #21

jescalan commented 9 years ago

Yeah, I feel like it's about time to remove iconic haha, based on that discussion

stephenlacy commented 9 years ago

It is odd as #263 seems to show that they 'might' be adding docs for it, while #197 shows font awesome and the removal of icon sets

jescalan commented 9 years ago

Yeah... I've thought about adding icon sets for axis, but decided against it. People have too varied of preferences and there are too many icon sets out there, bundling with one specifically just seems too narrow. What I would be cool with is some kind of helper that allows you to load in your own icon set and/or have syntax shortcuts to access the icons, but that seems like it would be pretty difficult.

ghost commented 9 years ago

Because of the very similar avatars it took me a while to realize you were not talking to yourself. Could you elaborate a bit more? How do you picture this helper would look like?

notslang commented 9 years ago

Haha, sorry - that must have looked pretty strange! @jenius and I both work at Carrot so we got "carrotized" avatars courtesy of our design team :smile:.

And for the helper, it would probably be a wrapper for adding the font-face rules, and a way to inject the icons based on their names, rather than knowing which character a particular icon is assigned to, or needing to put classes in your markup. Though it would be pretty difficult to do this in a generic way that works for all icons sets... especially if you wanted to be able to swap out icon sets and still have the same meaning for an icon.

IMO, the best solution to this would be to remap icon fonts to use the unicode emoji blocks, and then make a standard section of a private block for various icons that aren't defined elsewhere in unicode (like social icons, or very specific UI icons). But that would also be difficult because we'd need to do the mapping manually for all the icon sets we want to support.

Tho maybe @jenius had a better idea...

ghost commented 9 years ago

No worries. I think having an all-mighty font-face function #21 to do the grunt work is not a terrible idea but, why not just completely drop out Iconic or any support for icons? Remapping icon fonts to use emoji would be nice, but nib's main dish are gradients and buttons, the reset and normalize are nice things to have, but it would be tidier and prettier without so many features.

Maybe someone can write a tutorial about how to use your favorite icon solution with nib and that could be added to the docs.

hrieke commented 2 years ago

More interesting question in my mind is which version of Iconic is used - the commercial version or Open Iconic? Be nice and include the information in the documentation. Thanks!