search

stylus / nib

Stylus mixins, utilities, components, and gradient image generation
http://stylus.github.io/nib
MIT License
1.9k stars 250 forks source link

Reseting opacity in IE when !important #294

Closed fiskus closed 9 years ago

fiskus commented 9 years ago

Hello, there is little mistyping in opacity mixin. All conditions have support of denoting "!important" except case with "100%/none" value.

notslang commented 9 years ago

Thanks, @fiskus! Thought before I merge, could you add test cases for opacity at 100%/none, so this never regresses?

fiskus commented 9 years ago

Test added. I don't realy into IE8 and stuff. So I added expected values as nib generated them now.

I mean, correct values are: -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=100)" filter: alpha(opacity=100);

But nib provide: -ms-filter: none filter: none;

I think it was done for better performance.

fiskus commented 9 years ago

Tests on my machine successfully passed. node v0.10.33

Log on https://travis-ci.org/tj/nib/jobs/43848020 said there is no compatible version of should-type package.

notslang commented 9 years ago

Hmm... looks like a problem with should.js

notslang commented 9 years ago

Ok, it's just an issue with an outdated version of npm running on travis that can't handle the circumflex that should used in their package.json. 72cf21856eba53c28395db9b55f388762bf9529e should fix it

fiskus commented 9 years ago

Thanks. Your fix merged. Now all is ok.

notslang commented 9 years ago

Thanks, merged here: afa4bfed12b7309d93d5bf4def3849f698d70a9f (rebased it to get rid of the extra commit)