search

styxit / HTPC-Manager

A fully responsive interface to manage all your favorite software on your Htpc.
http://htpc.io
MIT License
529 stars 183 forks source link

docker: add initial support #293

Closed dz0ny closed 6 years ago

dz0ny commented 10 years ago

Deploys app as docker container

build with docker build -t htpc https://github.com/dz0ny/HTPC-Manager.git run with docker run -p 8085:8085 htpc

styxit commented 10 years ago

Can these two files be put in a docker folder? The requirements.txt file is docker specific i guess, but now it looks like this is always required.

dz0ny commented 10 years ago

@styxit lol https://pip.readthedocs.org/en/1.4.1/cookbook.html#requirements-files

styxit commented 10 years ago

Im not a PIP or Docker expert so "lol" is not really helping me

dz0ny commented 10 years ago

If you have written app in python it is strangely you never came across PIP as it is essential to python development. The basic idea is to freeze dependencies to know working versions of libraries you use in project. You however are manually copying source code from god knows where and really not caring about stable updates... it's bad practice. Especially as this seems to be hobby project, you could really save some time by using standard tools and not reinventing the wheel or expose users to vulnerabilities.

styxit commented 10 years ago

You are right, I used PIP to install some stuff. But Pillow or psutil is not required. Is is recommended, but can run without it.

I wanted to keep a low level entry and not require some users who don't know how use or install PIP to still be able to use it. The only real requirement is python 2.7 if i am correct.

Hellowlol commented 9 years ago

I think this is a great idea. If there was a comment in the requirements.txt that explained that it isnt needed to run but is recommended.