su-fit-vut / kachna-online

Students' Club U Kachničky: Member's portal
MIT License
5 stars 5 forks source link

Notify when club state is ending #119

Closed lukynmatuska closed 2 years ago

lukynmatuska commented 2 years ago

Please add notification about end of chillzone for example.

Because LeO don't like when calendar look like this: Screenshot_20220504_115714

KachnaBot webhook should send message with tag of chillmaster to #chillzone-log channel for example.

So chillmaster can extend the current chillzone (or other club state).

ondryaso commented 2 years ago

This would require reworking the StatePlannerBackgroundService and its callers to wake up earlier than at the end of a state, trigger the 'pre-end' actions and then sleep until the end of the state. I don't think this would be too much work but it would require thourough testing of the state lifetime thing which is non-trivial.

However, I don't really think this is necessary. To make the calendar less cluttered, I think it would be better to just merge successive events of the same type (that could be done either on backend or on frontend; I'm not entirely sure which of these two options would be better).

Most importantly: People that open a chillzone should be aware of what they're doing. They've got responsibility for the club; if you aren't able to remember what time you opened for, I'm not sure if you're capable of watching over the club and all the people in it. 😄 I'm sure you wouldn't mind but in my opinion, this would only create more useless clutter in the #chillzone-log channel.

If you come up with some good reasoning for why this should be implemented, I may re-open this issue.