su-fit-vut / kachna-online

Students' Club U Kachničky: Member's portal
MIT License
5 stars 5 forks source link

Do not allow push configuration to be null #66

Closed FrNecas closed 2 years ago

FrNecas commented 2 years ago

It would throw an exception.

ondryaso commented 2 years ago

And what exactly happens when you do this? Doesn't it throw an exception when you call the notifications endpoint and attempt to make a subscription? I would expect it to. If it does, you've just pushed the problem around to a different place.

I don't think it's wrong to throw an exception during startup when the app is misconfigured. Certainly better than throwing them in the endpoints.