su2code / SU2

SU2: An Open-Source Suite for Multiphysics Simulation and Design
https://su2code.github.io
Other
1.31k stars 836 forks source link

Axisymmetry for SA is not implemented #1565

Open bigfooted opened 2 years ago

bigfooted commented 2 years ago

Describe the bug A clear and concise description of what the bug is and what you expect the behavior to be instead. If applicable, add screenshots to help explain your problem.

2D axisymmetry source terms for the SA turbulence model are not implemented. There is also no warning/error to the user.

TobiKattmann commented 2 years ago

An error for SA+axissymmetry is introduced in #1571. So this then now labels as a feature-request :)

WallyMaier commented 2 years ago

If anyone has a source for this, Id be interested in adding this.

bigfooted commented 2 years ago

@WallyMaier I don't have a reference showing the specific terms for SA, but you can derive it from the general transformation from Cartesian to cylindrical coordinates. It looks like the only term that is affected is the diffusion term. The appendix of Transport Phenomena (Bird, Stewart, Lightfoot) shows some Cartesian and cylindrical forms for a general scalar transport equation. The result is that the divergence of a flux in Cartesian coordinates is $$(1/r) (d/dr)(rJx) + (1/r)*(d/d theta)(J{theta}) + d/dz(J_z)$$ and we neglect the theta-term in axisymmetric flow.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

bigfooted commented 1 year ago

I'm working on this. https://github.com/su2code/SU2/tree/feature_SA_axisymmetry

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

pcarruscag commented 1 month ago

Now it's implemented but it's missing the curvature correction