search

su2code / SU2

SU2: An Open-Source Suite for Multiphysics Simulation and Design
https://su2code.github.io
Other
1.31k stars 836 forks source link

Jacobian of BC_HeatFlux_Wall in TurbSASolver #2342

Open Wang-Lancelot opened 1 month ago

Wang-Lancelot commented 1 month ago

In CTurbSASolver.cpp line 496, the Jacobian_i = (laminar_viscosity*Area)/(0.03*Roughness_Height*sigma);

Should it be Jacobian_i = (laminar_viscosity /density *Area)/(0.03*Roughness_Height*sigma); ?

pcarruscag commented 4 weeks ago

Seems that way, can you open a pull request to fix it?

Wang-Lancelot commented 4 weeks ago

Sure, I will open one later.

Seems that way, can you open a pull request to fix it?

vkrm1612 commented 2 weeks ago

Hey, I want to make this change...!

Wang-Lancelot commented 2 weeks ago

Hey, I want to make this change...!

Sure, if you are willing to, please make it. Thank you so much for your help.