su2code / SU2

SU2: An Open-Source Suite for Multiphysics Simulation and Design
https://su2code.github.io
Other
1.37k stars 842 forks source link

Fix aachen testcase #2367

Closed alecappiello closed 1 month ago

alecappiello commented 1 month ago

Proposed Changes

I discovered that the Aachen regression test was actually on its way to divergence. I think this explains why the regression test was behaving inconsistently, although I'm not sure about what caused this problem.

I made a new mesh, introduced wall functions as suggested by @joshkellyjak, and switched to second order directly. The convergence history is good. See the attached convergence histories obtained with JST starting from scratch with outlet pressure ramp. conv_hist_rotor1 conv_hist_stator1 conv_hist_stator2

I have finally updated the restart files accordingly.

Related Work

I think these small changes could fix the issues encountered in the past with this test case.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

joshkellyjak commented 1 month ago

@pcarruscag I think we may have spoken about this before but my memory does not serve me well, do you have any idea as to why the residual values change when we remove the entropy fix coeff?

pcarruscag commented 1 month ago

hmm maybe boundaries, we still use the Roe scheme on boundaries even with JST, I stand corrected.