search

su2code / SU2

SU2: An Open-Source Suite for Multiphysics Simulation and Design
https://su2code.github.io
Other
1.34k stars 844 forks source link

Bug in CSourceAxisymmetric_Flow::ComputeResidual #454

Closed vdweide closed 7 years ago

vdweide commented 7 years ago

I am trying to run an axi-symmetric case with a time stepping scheme (basically SOD's problem), which fails in CSourceAxisymmetric_Flow::ComputeResidual. The reason is that the boolean implicit is determined as follows

bool implicit = (config->GetKind_TimeIntScheme_Turb() == EULER_IMPLICIT)

However, this must be config->GetKind_TimeIntScheme_Flow, right?

Furthermore, the small y-coordinate case will also fail, because there is no test whether an implicit computation takes place. I can correct this, if somebody can confirm this is indeed a bug.

Edwin

economon commented 7 years ago

@vdweide: yep, definitely a bug. Only the mean flow solver uses that routine. Please feel free to clean this up. I would also like to update the version for the incompressible solver (I think it needs a fix or two)... but we'll get to that after your changes.

vdweide commented 7 years ago

OK, I'll do that. And as far as I can see it, also the viscous contributions to the axi-symmetric source terms are missing.

vdweide commented 7 years ago

I just created the PR for this.