Closed talbring closed 5 years ago
I like this a lot. I often have a hard time reading the free-stream conditions, and this makes it a lot easier to read. Don't think it is as necessary for the solver iterations, but I don't see any detriment to outputting it like that. Would this require changing the regression testing script that reads the output log to diff the numerical values?
This is very nice! The free-stream / reference values look so much better. My only suggestions would be to add a blank space between the value and the column separator and use + at every intersection for consistency.
+-------+---------------+------------+
| Index | Marker | Elements|
+-------+---------------+------------+
| 0 | airfoil | 128 |
| 1 | farfield | 352 |
+-------+---------------+------------+
I like this a lot, but I agree with Jayant that it may be not necessary for the solver iteration. Perhaps we could add the + at intersections but remove them from the external bounds.
Like it a lot, thanks, Tim! 👍
I also think it could be nice to leave the vertical bar out of the solver iterations. Is it easy to just have a flag for this in the table class constructor for customizing or perhaps a method to turn off/on (without making too much work for you, of course)?
Thanks for the feedback. I will modify the class in a way that it is possible to specify the separator and other decoration.
Contributed in #633. Closing
Along with the restructuring of the output internals (see branch feature_output), I am introducing a more structured and unified way of outputting tables on screen. This enables for example a more structured output of the preprocessing information that is printed on screen at the beginning.
For the table output I use a very simple and easy to use class. For example the table
is generated using the code
An example of the current preprocessing output in the feature_output branch can be found below. Especially the information for the free-stream and non-dimensionalization is more readible this way. Furthermore the convergence history uses the same table class.
Let me know what you think. Any comments are appreciated.