search

su2code / SU2

SU2: An Open-Source Suite for Multiphysics Simulation and Design
https://su2code.github.io
Other
1.34k stars 844 forks source link

Bug in CDriver.cpp #792

Closed koodlyakshay closed 5 years ago

koodlyakshay commented 5 years ago

Hello,

There is a stray allocation in the Integration_Postprocessing routine in line 1804 in the develop branch.

Currently reads:

if (template_solver) integration[val_iInst][TEMPLATE_SOL] = new CSingleGridIntegration(config);

instead of delete. Is this resolved in a more recent PR?

Cheers, Akshay

talbring commented 5 years ago

@koodlyakshay Thanks for mentioning. That's indeed a bug. Will remove it in one of my PRs.

koodlyakshay commented 5 years ago

Hi @talbring ,

Also I noticed there is no breakdown file being written for incompressible problems. I suspect this is because the flow boolean in the SpecialOutput_ForcesBreakdown routine only checks for EULER, NS and RANS but not the INC versions of those.

Cheers, Akshay

talbring commented 5 years ago

@koodlyakshay Thats already fixed in #724 !