su8 / pinky-bar

Gather some system information and show it in this program
GNU General Public License v3.0
14 stars 5 forks source link

CPU percents, hertz, and RAM #18

Closed lasers closed 6 years ago

lasers commented 6 years ago

I caught myself trying --coreloads instead of --coresload. I think this is not a good name because I made a mistake. Lol. I suggest this solution to make it more friendly for users.

EDIT: Does it make sense to display --cpu-hertz (averaged out)? EDIT2: grep MHz /proc/cpuinfo EDIT3: Maybe for --cpu-hertz* stuffs, fix --shell first and use that instead.

su8 commented 6 years ago

Does it make sense to display --cpu-hertz (averaged out)

It shows the maximum cpu clock speed regardless of the used cpu governor

Will rename cpu and coresload.

lasers commented 6 years ago

It shows the maximum cpu clock speed regardless of the used cpu governor

You're right. I tested it with watch -n0 grep MHz /proc/cpuinfo. Not worth adding. Thanks for others. :+1:

lasers commented 6 years ago

Add --ram-used Used RAM, in MB too. And slightly unrelated, --title is broken for me.

su8 commented 6 years ago

It's called --ramused

lasers commented 6 years ago

Yes it is. Sorry. I didn't see it with other RAM options, but is there at bottom of the list.

lasers commented 6 years ago

When you -l (lowercase L), do you get --ramshared or --ramused in OpenBSD? Both same?

su8 commented 6 years ago

--ramused

https://github.com/su8/pinky-bar/blob/1603b9f41ff8c3e5b26d44cab1119105642841eb/src/openbsd_functions.c#L56

lasers commented 6 years ago

Kill -l for --ramused so we can combine it and put it with other RAM options? (Linux, OpenBSD)

su8 commented 6 years ago

If I "kill" it, the parser will be broken as it expects the key "-l" whenever it's compiled for linux it will be ram shared, otherwise when compiled for OpenBSD it will be ramused. They both share the same key, except when compiled on one platform the long command differs from the long command on another platform.

lasers commented 6 years ago

Request to remove RAM in all --ram* options. Allow 1024/8192 or such. Ty.

su8 commented 6 years ago

Running out of time, have to go to work. Will do these changes in the weekend or when I have more time, thanks.