search

su8 / pinky-bar

Gather some system information and show it in this program
GNU General Public License v3.0
14 stars 5 forks source link

Require an additional argument --with-colors #39

Closed lasers closed 6 years ago

lasers commented 6 years ago

./configure --prefix=$HOME/.cache --with-py3stauts --with-colors will produce dzen2 color instaed of py3status color. It didn't take long to find my mistake.

./configure --prefix=$HOME/.cache --with-colors (not specified) will also produce dzen2 color.

I think there should be a --with-dzen2 color argument and that if we supply --with-colors without specifying which one, then it should either print the output without colors or to stop there (error).

Twas a typo.

lasers commented 6 years ago

I'm not sure if we would need --with-colors anymore.

su8 commented 6 years ago

with-py3stauts is mistyped that's why it defaults to dzen2. You'll get some warning that there is no such configure option.

su8 commented 6 years ago

I think there should be a --with-dzen2 color argument and that if we supply --with-colors without specifying which one, then it should either print the output without colors or to stop there (error)

Will make those changes in the weekend, thanks for the suggestion. ♥

su8 commented 6 years ago

Should be fixed in the latest commit. Thanks for reporting this issue.

lasers commented 6 years ago

New features tested okay. I love it that we have one less favoritism in the code. Thanks! :-)