search

sualfred / script.embuary.helper

Helper script for Embuary Kodi skin
17 stars 13 forks source link

Change Next Up to show next unplayed episode #32

Closed MoojMidge closed 4 years ago

MoojMidge commented 4 years ago

Hi Sualfred,

Just noticed that the Next up widget shows the first unplayed episode for a TV series, rather than the next unplayed episode after the previously played episode.

This normally wont be an issue if all episodes are watched in order, but this is not necessarily the case especially with anthology shows where, for example, you might start watching Season 3 of the show without having watched the previous seasons. In this instance the Next up widget will always show Season 1 Episode 1, rather than the next episode in Season 3.

Would you consider changing this behaviour?

Didn't know if there was a way to do this directly so had to resort to two queries - the first to find the last played episodes and then another to find the next episodes.

Cheers

sualfred commented 4 years ago

Thanks. This is a corner case and some people might disagree to the change. But I can add an optional setting for this behaviour. I'll cherry pick your changes and keep this PR open until I've adjusted it with my modifications and changes.

sualfred commented 4 years ago

@MoojMidge Please give this a try: https://github.com/sualfred/script.embuary.helper/commit/22cc51b750cd9196935342ddc80ae5b645decb2c

It should pick the first unwatched episode of the last watched season of the shows. Plus I've added a fallback to the very first unwatched episode if the last watched season has no unwatched episodes left.

sualfred commented 4 years ago

I'll close this PR because my logic fits more. But thanks for your suggestion and the PR. This will be the default behaviour now.