suavecode / SUAVE

An Aircraft Design Toolbox

suave.stanford.edu

GNU Lesser General Public License v2.1

414 stars 401 forks source link

Turboelectric HTS Dynamo Ducted Fan Network #555

Closed sofie-0 closed 2 years ago

sofie-0 commented 2 years ago

Pull Request Checklist

Merge in the latest Develop branch changes to your branch
Remove .pyc files from your repository:
- Linux/Mac
  - find . -name *.pyc -delete
- Windows
  - del /S *.pyc
Run automatic regression and makes sure everything is passing
Did you make a new regression test that covers your new code?
Did you update your docstrings?
Did you update your headers to include your name and date?
Do a final compare with the Develop branch to be sure what you're changing

coveralls commented 2 years ago

Coverage increased (+0.1%) to 90.33% when pulling 19797849d15854027ea66f61e7af89e765177da4 on Sof222:develop into a3b8af42a06ab1d650dd32abc8354fe547d03e89 on suavecode:develop.

sofie-0 commented 2 years ago

Do you know why the coverage check isn't producing an output?

planes commented 2 years ago

Do you know why the coverage check isn't producing an output?

I just restarted it. Let's see what it does.

planes commented 2 years ago

Do you know why the coverage check isn't producing an output?

I just restarted it. Let's see what it does.

It's producing a report: https://coveralls.io/jobs/97774440 But GitHub isn't receiving the result somehow.

planes commented 2 years ago

Hey! I approved these changes. When ever you're ready feel free to merge it. Nice work!

sofie-0 commented 2 years ago

Hey! I see the changes are approved but I don't believe I'm able to merge them.