suavecode / SUAVE

An Aircraft Design Toolbox

suave.stanford.edu

GNU Lesser General Public License v2.1

401 stars 392 forks source link

Feature new airfoil distribution #615

Closed mclarke2 closed 1 year ago

mclarke2 commented 1 year ago

Pull Request Checklist

Merge in the latest Develop branch changes to your branch
Remove .pyc files from your repository:
- Linux/Mac
  - find . -name *.pyc -delete
- Windows
  - del /S *.pyc
Run automatic regression and makes sure everything is passing
Did you make a new regression test that covers your new code?
Did you update your docstrings?
Did you update your headers to include your name and date?
Do a final compare with the Develop branch to be sure what you're changing

coveralls commented 1 year ago

Coverage increased (+0.04%) to 90.262% when pulling 87481862cc1c426be834ebbd5a42e980d156ca06 on feature-new_airfoil_distribution into 13844373554718d795b73f392f2d203d9b60e732 on develop.

planes commented 1 year ago

Yeah that's good to use the container ordered. If you delete the append_airfoil function does everything work?

mclarke2 commented 1 year ago

No, similar to other physical components, the append_airfoil function is needed