suavecode / SUAVE

An Aircraft Design Toolbox

suave.stanford.edu

GNU Lesser General Public License v2.1

401 stars 392 forks source link

added dCY_dbeta to compute_aero_derivatives #629

Closed danielenriquez59 closed 1 year ago

danielenriquez59 commented 1 year ago

Pull Request Checklist

Merge in the latest Develop branch changes to your branch
Remove .pyc files from your repository:
- Linux/Mac
  - find . -name *.pyc -delete
- Windows
  - del /S *.pyc
Run automatic regression and makes sure everything is passing
Did you make a new regression test that covers your new code?
Did you update your docstrings?
Did you update your headers to include your name and date?
Do a final compare with the Develop branch to be sure what you're changing

planes commented 1 year ago

Appveyor won't pass until this line is updated too: https://github.com/suavecode/SUAVE/blob/451195b03b3b0bd70bdbbd4d8f8247c484cef6b2/trunk/SUAVE/Analyses/Aerodynamics/Vortex_Lattice.py#L434

danielenriquez59 commented 1 year ago

trying again after addressing the comment on line 434.

planes commented 1 year ago

The 737 is failing because there is no default value for dCY_dbeta. Update this similarly to these:https://github.com/suavecode/SUAVE/blob/188dc7aee3e32e12658e7d6ccc6f69d7be3ed0ef/trunk/SUAVE/Methods/Flight_Dynamics/Static_Stability/compute_aero_derivatives.py#L119

danielenriquez59 commented 1 year ago

trying again after addressing the "default value" comment

coveralls commented 1 year ago

Coverage increased (+0.0005%) to 90.318% when pulling 8236dd754872be96727ce7ca71672cf748b355e8 on danielenriquez59:develop into b16eb3f494d8da04a8c8465211ad43e630f66fa8 on suavecode:develop.