suaveolent / ha-hoymiles-wifi

Home Assistant custom component for Hoymiles DTUs and the HMS-XXXXW-2T microinverters
MIT License
129 stars 9 forks source link

Name of Inverter is wrong #41

Closed ShadowJumper closed 2 months ago

ShadowJumper commented 3 months ago

Describe the bug When i´m add a HMS-1000W-2T, in HA it shows as HMS-800W-2T

To Reproduce Steps to reproduce the behavior: Add an HMS-1000W-2T

Screenshots 2024-06-03 21_18_37-Einstellungen – Home Assistant 2024-06-03 21_19_46-S-Miles Cloud - Hoymiles Power Electronics Inc

suaveolent commented 3 months ago

Thanks for reporting. I try to retrieve the inverter model via the serial. Can you maybe post the first 6 digits of your serial number?

ShadowJumper commented 3 months ago

Yes, this was the 141293.

I also have an HMS-800W-2T, so if it helps i can make some tests with booth of them.

suaveolent commented 3 months ago

Great. Does the Serial of your 800W-2T by any change start with 141292 ? If so I could distinguish between these two models.

ShadowJumper commented 3 months ago

I´m checked it, and yes, on my 800W-2T the serial starts with 141292.

suaveolent commented 3 months ago

Great, so I can distinguish between those two models.

ShadowJumper commented 3 months ago

I test your new version, and it works, but you have a typo in line 37 and 59. So you get -> ['HMS-10000W-2T'] instead of ['HMS-1000W-2T'].

suaveolent commented 3 months ago

Thanks! Fixed that now. I will most likely push a new version this week and afterwards close this issue.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 2 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.