search

subakva / haproxy-tools

Ruby tools for HAProxy, including config file management.
MIT License
32 stars 14 forks source link

Parsing fails when providing port with hostname. #6

Closed johnbellone closed 11 years ago

johnbellone commented 11 years ago

It is correct for only a single ':' to be there for a service address assuming IPV4. This was failing on a simple hostname and port example. This PR fixes #5.

subakva commented 11 years ago

Wouldn't this change just make the port mandatory? I don't think that would be correct in all cases.

I just made a fix on master that might be related. If there's another issue that this PR addresses, I'd be happy to pull it in along with a spec exercising the problem.

subakva commented 11 years ago

If you can share an HAProxy config file that fails to parse, I'd be happy to take a look at it.

johnbellone commented 11 years ago

I copied the wrong change I believe (did it through browser). I will try to get a configuration that fails. Its a quite big one.

JB

On Wed, Aug 7, 2013 at 8:17 PM, Jason Wadsworth notifications@github.comwrote:

If you can share an HAProxy config file that fails to parse, I'd be happy to take a look at it.

— Reply to this email directly or view it on GitHubhttps://github.com/subakva/haproxy-tools/pull/6#issuecomment-22294157 .

johnbellone commented 11 years ago

@subakva I woke up early to catch a train and it came to me - a digit at the end of the hostname. I was able to reproduce this with the test provided, and it seems my change to the DNS hostname rule works (passes all tests). See anything wrong?

subakva commented 11 years ago

Host names with numbers? What will they think of next? Thanks for the patch! I just pushed v0.3.1.