subasraj / flashpost-support

Flashpost is a lightweight Rest API Client Extension for Visual Studio Code.
MIT License
10 stars 0 forks source link

pill contrast is really bad #13

Closed BananaAcid closed 8 months ago

BananaAcid commented 9 months ago
Bildschirmfoto 2023-12-21 um 12 41 24

changing the font color would probably be way better for readability. Me and my colleagues I can barely read it.

subasraj commented 9 months ago

What vscode theme are you using? Please try the latest version (1.1.54 and above) of Flashpost and see if that fixes it.

BananaAcid commented 9 months ago

„Ayu“ Mirage.

https://marketplace.visualstudio.com/items?itemName=teabyii.ayu

Didn‘t actually think about it, as we all use the same one around here. Thinking about it: Is this extension using a default css-variable for the text color that is set by my theme?

subasraj commented 9 months ago

Yes its using the default css-variable for the text color that is set by your theme. it's using color: "var(--vscode-foreground)" Its the same for your workspace and same for Thunder client. Closing this issue.

BananaAcid commented 8 months ago

And for the pill color? Is it a fixed color? In that case, I believe, the foreground color for the pill should be a fixed one as well, to not cause problems for any theme.

subasraj commented 8 months ago

@BananaAcid Fixed the Pill Color. Please try the latest version 1.1.56

BananaAcid commented 8 months ago

Sadly, does not seem to work. seems to be a problem on al MacOS, Windows seems fine (with the same theme/and others).

Bildschirm­foto 2023-12-23 um 16 13 56
subasraj commented 8 months ago

I have a mac and it works properly

BananaAcid commented 8 months ago

Yes its using the default css-variable for the text color that is set by your theme. it's using color: "var(--vscode-foreground)" Its the same for your workspace and same for Thunder client. Closing this issue.

@subasraj maybe this helps debugging:

VSCode Inspector shows, it uses (for the request area, left to the url textbox):

.request-method-drop-down {
    /* ... */
    color: var(--button-text-color);
    /* ... */
}

you seem to reference (which does not seem to be applied ehen using the inspector)

.request-method-drop-down option {
  color           : var(--text-color);
  /* ... */

and for the collections view also the text button color:

.mtd-wrapper3 {
    /* ... */
    color: var(--button-text-color);
}

--button-text-color: var(--vscode-button-foreground);
subasraj commented 8 months ago

Changed request-method-drop-down. mtd-wrapper3 in my code is already changed. Please try the latest version again.

BananaAcid commented 8 months ago

Yes works flawlessly - switched themes -- all fine