search

subchannel13 / EnchantedFortress

A simple game about managing resources of a fortress. Distribute your workforce, survive demon attacks and find a way to stop demon threat.
GNU Lesser General Public License v3.0
59 stars 10 forks source link

Optimize image sizes #71

Closed TPS closed 4 years ago

TPS commented 4 years ago

@subchannel13 I noticed that the F-Droid-built APK recently increased in size 10×. This is a quick-&-simple effort to help with that. Since ImgBot is free for open-source, maybe y'all should signup to have it maintain automatically?

subchannel13 commented 4 years ago

Thank you for PR! I'll check ImgBot out, first time I've heard about it.

The reason APK size increased was adding androidx.appcompat dependency (part of night mode feature). I did it with a heavy hearth but at least it help me sort out other legacy Android support issues. Images in your PR do shave of ~10 kB out of 1200 kB so it won't change the size that much but it doesn't hurt :).

subchannel13 commented 4 years ago

I've reviewed PR changes, images looks unchanged. There seems to be very slight color brightness change but in production it should be next to unnoticeable since those images cover very little screen space.

One thing I'd ask you to change is to remove changes to images in fastlane/metadata/android/en-US/images/phoneScreenshots/ folder. Those images are for F-Droid store and are not built in APK.

TPS commented 4 years ago

The screenshots might be as important to optimize, as they're presumably downloaded @ least as often as the APKs.

subchannel13 commented 4 years ago

That is an assumption we cannot check due to lack of analytics. It doesn't hurt anyway so I'll merge PR. Under which name do you want to be credited in game's "about" section?

TPS commented 4 years ago

@subchannel13 I'd prefer you give credit to @dabutvin, who's the lead/coordinating dev on ImgBot. If you feel the need to mention me anyway, @TPS is just fine.