subconsciousnetwork / subconscious

Apache License 2.0

6 stars 0 forks source link

Implement Modal Editor Sheet #1141

Closed bfollington closed 3 months ago

bfollington commented 3 months ago

Fixes https://github.com/subconsciousnetwork/subconscious/issues/1057

Preserves existing editor as-is unless the Developer Setting is enabled.

Next up: integrate into all views / contexts.

Tasks

[x] Add developer flag to enable/disable
[x] Cleanup code
[x] Modify audience from inner sheet
[x] Modify link from inner sheet
[x] Post / save on button, auto assign audience
[ ] Explore animation performance with large text

https://github.com/subconsciousnetwork/subconscious/assets/5009316/8524e2ad-9edf-4fb4-b5ae-18a27aa79261

bfollington commented 3 months ago

@gordonbrander Just FYI, as part of this PR I've addressed:

Refining spacing of header
Use disc style for close button, ensure we match native dimensions

and, RE: Refine Post/save flow, I believe it already works the way you're describing with the additional layer of "Save" only appears when there are currently unsaved changes to a public note.