Revert "added mask/unmask button for master password input (#169)"

subdavis / Tusk

🐘 🔒 KeePass-compatible browser extension for filling passwords.

https://subdavis.com/Tusk

Other

482 stars 74 forks source link

Revert "added mask/unmask button for master password input (#169)" #192

Closed subdavis closed 6 years ago

subdavis commented 6 years ago

This reverts commit 9eec0c1c7faa24478dff002c19dc0d67f30ac417.

CC @realprogrammer - please be aware of danger for the future :) because we both missed it.

reverts #169

fixes #191

martinschwinzerl commented 6 years ago

Original bug report author here, thank you very much for quickly fixing this!

Being myself sadly no longer entirely up-to-date when it comes to these things anymore, but shouldn't the autocomplete="off" (or maybe even autocomplete="nope", according to this: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion) attribute for the input field be usable to prevent this?

subdavis commented 6 years ago

Entirely possible! I'm a bit preoccupied with some other tasks at the moment, and didn't have the time to find and test a fix as thoroughly as I think is necessary for this issue.

I was most confident reverting the feature until it can be properly understood.

I'll keep the autocomplete option in mind for a future fix. Thanks again.