search

subdavis / Tusk

🐘 🔒 KeePass-compatible browser extension for filling passwords.
https://subdavis.com/Tusk
Other
480 stars 74 forks source link

Argon2 WASM implementation is too slow. #212

Open wolffx86 opened 6 years ago

wolffx86 commented 6 years ago

This issue is a

Please describe the current behavior, and explain why it's bad.

The issue is whenever i enter my master pw (whether it's right or wrong) it takes ~90sec for it to either return an error that the pw is invalid, or to give me the available credentials for the current tab. I noticed it is quicker to open after the initial unlock for pages that have already been "allowed".

Please describe how you think it should change.

Faster unlocks.

subdavis commented 6 years ago

This is a known issue of argon2 on the web. Thanks for raising this issue. There is probably nothing we can do about it for the short term.

You can set your argon 2 hashing rounds down to a lower number to speed things up if you want.

wolffx86 commented 6 years ago

Thanks for the quick response.

Where is that setting at?

subdavis commented 6 years ago

Tusk is read only. You'll need to use a full KeePass app like KeePassXC.

In file -> database settings there should be some options to set your crypto preferences.

uncon commented 6 years ago

@subdavis Out of curiosity, can you point me towards some additional information on this known issue? I find it interesting that KeeWeb opens my database in 8.5 seconds but Tusk takes 33.0 seconds on the same device. (Keepass2Android takes 9.0 seconds on my phone.)

wolffx86 commented 6 years ago

Keepass2Android doesn't even take 9 seconds back before i changed the hashing rounds for Tusk. It was usually instant after completing the password entry @uncon. that's why i was a bit confused why Tusk was taking forever.

zmilonas commented 5 years ago

I think since there is nothing we can do about it I'll close it. Also if anything keeweb can be blamed since that's the library that is used for decryption.

subdavis commented 5 years ago

I'm not ok with closing this yet. @uncon and @wolffx86 make a good point about how it takes longer on Tusk than KeeWeb.

qmeeus commented 5 years ago

I had the same problem, I can confirm that changing the key derivation algorithm from Argon2 to AES drastically decreases the time needed to unlock in Tusk: Database > Database settings > Encryption > Key Derivation Function > switch to something lower

Please give an update here if you ever fix this issue