search

subdavis / Tusk

🐘 🔒 KeePass-compatible browser extension for filling passwords.
https://subdavis.com/Tusk
Other
476 stars 73 forks source link

Add Travis CI + Code Coverage. Rework Limited Subset of Tests to use CLI #235

Closed bowerscd closed 5 years ago

bowerscd commented 6 years ago

Solves #16 .

Requires:

  1. Personal Access Token with either 'Repo' or 'Public Repo' Scope
    • Allows Automated Releases on Integration To Master
  2. Travis CI Account/OAuth Grant
    • Allows Travis CI to Function
  3. Coveralls.io Account/OAuth Grant
    • Allows Code Coverage Information
subdavis commented 6 years ago

Oh neat. I'll look at this asap. Thank you.

bowerscd commented 6 years ago

For the remainder of the tests, the easy-but-tideous way to make them compatible with CLI is to make an abstraction layer for the browser, which should mock the functions if the environment is node vs a browser.

It's a lot of effort, though, and there's a much higher change of a breaking change without regression tests.

zmilonas commented 6 years ago

Great contribution!

zmilonas commented 6 years ago

Although all these whitespace changes are a little worrisome

bowerscd commented 6 years ago

The white space errors are due to the ‘beautify’ check of the CI. These files were indented with tabs, not spaces.

They are a consequence of running js-beautify on the files (see ./ci/beautify.sh)

Otherwise the CI definition wouldn’t allow me to integrate and merge the changes.

subdavis commented 6 years ago

Oh bugger. develop is the main branch. I hardly bother with master. We can get master back on track, but this PR should be made into develop

zmilonas commented 6 years ago

@bowerscd I noticed that it changed tabs into spaces :P but some time ago when I started to contribute to this project @subdavis mentioned he chose to use tabs, for better or for worse. Has your mind changed now @subdavis? :smile:

zmilonas commented 6 years ago

As for the whole thing, I was researching just a day ago CircleCI and Travis to implement for the puppetter tests I'm writing. Great to see you took the time to write a nice pipeline conf. Thanks

bowerscd commented 6 years ago

Regarding the tabs/spaces change, @subdavis if you want to keep them as tabs it's an easy change and a dotfile to ensure that it is consistent across js-beautify.

bowerscd commented 5 years ago

Closing per @subdavis ' comment:

Oh bugger. develop is the main branch. I hardly bother with master. We can get master back on track, but this PR should be made into develop

See #241 for the pull into develop