search

subdavis / Tusk

🐘 🔒 KeePass-compatible browser extension for filling passwords.
https://subdavis.com/Tusk
Other
475 stars 73 forks source link

Hidden inputs breaking autofill on adjacent fields #245

Closed fmunch closed 5 years ago

fmunch commented 5 years ago

This issue is a

bug

Steps to reproduce - current behaviour

  1. Add an entry to your Keepass database with the URL https://www.creditmutuel.fr/fr/authentification.html
  2. Go to https://www.creditmutuel.fr/fr/authentification.html
  3. Focus the "Identifiant" (username) field.
  4. Hit Ctrl+Shift+Space to autofill username and password.
  5. The username is filled but not the password.

What is the expected behaviour

The autofill should fill both username and password fields.

Additional remarks

The problem comes from the hidden inputs sitting between the username and password fields in the form, making them not adjacent.

The inputPattern in inject.js does not seem to be used anymore since 4d856b1, hence the hidden inputs not being filtered.

Environment

Operating System: Windows 10 64 bits

Browser: Chrome 71.0.3554.4 64 bits

Storage: WebDAV (Nextcloud)

zmilonas commented 5 years ago

Great suggestion. Thank you!

Although we already have an issue for tracking autofill problems, your investigation into specific code snippet causing the issue is greatly appreciated! I'm gonna close this issue and repost your remarks in that issue.

duplicate of #197