search

subdavis / Tusk

🐘 🔒 KeePass-compatible browser extension for filling passwords.
https://subdavis.com/Tusk
Other
475 stars 73 forks source link

WebDAV picks up files with wrong extension #266

Open henryptung opened 5 years ago

henryptung commented 5 years ago

Bug report

Steps to reproduce - current behaviour

  1. Set up WebDAV share containing passwords.kdbx
  2. Create passwords.kdbx.bak backup file as copy
  3. Link Tusk to WebDAV share
  4. Tusk picks up two databases, passwords.kdbx and passwords.kdbx.bak

What is the expected behaviour

- Tusk picks up single `passwords.kdbx` database #### Additional remarks

This documentation suggests Tusk should only pick up *.kdbx files, but this line pulls *.kdbx* instead, including files like a.kdbxbcdef.g. Probably should use endsWith instead?

Environment

Operating System:

Arch Linux

Browser vendor and version:

Chromium 69.0.3497.100

Storage Provider:

WebDAV

subdavis commented 5 years ago

Good catch.

I've come up against this enough times that I want to make file extensions configurable. Some folks may want .kdbx.bak to be visible in the same way that some misguided people insist on saving their password files as a .png

It would make sense to have a comma separated list of file extensions that Tusk can scan for.

Let's roll this issue into a feature request and fix it as part of that.

Sound good?