search

subdavis / Tusk

🐘 🔒 KeePass-compatible browser extension for filling passwords.
https://subdavis.com/Tusk
Other
475 stars 73 forks source link

A2Module is not defined #269

Closed k-wax closed 5 years ago

k-wax commented 5 years ago

I'm running a nextcloud instance on yunohost that stores my kdbx. I set Tusk to look for it via WebDav, all good here. After unlocking the db i get an error: "A2Module is not defined" and the db stays locked. Is this an apache2 configuration issue?

Xiphan commented 5 years ago

I've been getting the exact same issue for a while now in Firefox. I thought it was just something unique to my PC because I hadn't refreshed Firefox in a while. Except I just did that and the error still persists:

a2-module

I don't get this error in Opera, Chrome or Vivaldi.

subdavis commented 5 years ago

Great, so it's a Firefox related issue.

Thanks for the bug report. I'll check it out.

k-wax commented 5 years ago

Oops, yes. Firefox 63.0 on KDE Neon stable.

tasoili commented 5 years ago

Same problem on 64b4

benclark06 commented 5 years ago

Same problem on firefox 63.0.1 on windows

spvkgn commented 5 years ago

Same issue on FF63 Linux with Gdrive

jasperweiss commented 5 years ago

I was suspecting A2Module was a reference to Argon2. Indeed, opening a database with AES-KDF as its key transformation function opens just fine. It's databases that are configured with Argon2 that causes the problem on firefox.

subdavis commented 5 years ago

I'm really struggling with this one. Tusk 2018.9.27 works on FF 61, breaks on 63. Couldn't find anything helpful in the 62 or 63 changelog to see if wasm loading was altered.

According to the debug logs, argon2.wasm fails to load at all.

I need to go study what @antelle did in https://github.com/keeweb/keeweb/commit/32dcb3108566c64b120b56f79b069534eb276c13 -- I haven't really touched the argon2 bits since I added them last July, and I followed his lead. It looks like things changed last November and I never noticed the changes.

This may also solve #268, #212

Edit: I don't know why I'm having an issue with loading these scripts, but Antelle appears to side-step that by pre-compiling the webassembly in with require.js.

alensiljak commented 5 years ago

As reported in #276, I'm also experiencing the same issue with the current Firefox Developer.

image

subdavis commented 5 years ago

Thanks @MisterY. I've done a bit more research since the last comment, and I believe this can be solved with the wasm-loader webpack plugin.

Sorry this has taken a while to get to. I know it's a critical issue. As mentioned above, Firefox changed something between 61 and 63 that breaks WASM compilation, but they didn't mention it in the changelog.

alensiljak commented 5 years ago

No worries. I'll check again in the near future. If you need me to test some pre-release version, I'd be happy to, as well.

subdavis commented 5 years ago

This has been fixed and updated in the firefox store: version 2018.11.28

Please, PLEASE let me know if this does not solve your issue.

alensiljak commented 5 years ago

Thanks a lot! I can confirm that it works now (for me, at least). Now I can try out the features of the addon. So far it looks and behaves great.

epasch commented 5 years ago

This is now working for me as well. Thanks!