subdavis / Tusk

🐘 🔒 KeePass-compatible browser extension for filling passwords.
https://subdavis.com/Tusk
Other
468 stars 72 forks source link

Firefox: Shared URL provider doesn't work #307

Closed henryptung closed 5 years ago

henryptung commented 5 years ago

Bug report

Steps to reproduce - current behaviour

What is the expected behaviour

Shared URLs should work properly in Tusk.

Additional remarks

Guessing this might be related to differences between Firefox and Chrome in storage APIs, but AFAIK Firefox only promises to store JSON-ifiable values, which may not(?) include typed objects like SharedUrl.

The extension does work properly in Chrome, but the versions aren't a perfect match:

Environment

Operating System: Arch Linux

Browser vendor and version: Firefox 66.0.2 (64-bit)

Storage Provider: Shared URL

henryptung commented 5 years ago

Update after some research - looks like it's related to some weird bug with Firefox's local storage? For some reason, saving objects and then fetching them back loses all properties.

Update 2: Yup, this seems to be related to Vue and the way it decorates objects for observation (i.e. when they're added to the this.links array). I'll put up a PR.

paxet commented 5 years ago

Same happens to me (shared link don't work) with latest version of Firefox.

Operating system: Arch Linux / Windows 10 Browser vendor and version: Firefox 66.0.2 (64 bit) on both

janstuemmel commented 5 years ago

Hi, same issue here.

Using webdav for the moment is working with nextcloud

mishley commented 5 years ago

+1 same issue, haven't tried WebDAV with Nextcloud as above but will give it a shot.

mindobjects commented 5 years ago

Hi,

Do you have any idea of when a fix will be available ? Just try with latest Firefox beta 67 and it doesn't work.

Thanks for your work and reply.

Laura7089 commented 5 years ago

Identical issue here,

OS: Windows 10 LTSB/Arch Linux Browser: Firefox version 66.0.3 (64-bit)