suberra / funnel-contracts

Funnels are smart contracts that enforces renewable allowance as a proxy
MIT License
9 stars 0 forks source link

[Hacken 2022-11-25 Low #1] Floating Pragma #36

Closed zhongfu closed 1 year ago

zhongfu commented 1 year ago

Locking the pragma helps to ensure that contracts are not accidentally deployed using an outdated compiler version that might introduce bugs that affect the contract system negatively.

Paths

./src/Funnel.sol ./src/FunnelFactory.sol ./src/interfaces/IERC5827.sol ./src/interfaces/IERC5827Payable.sol ./src/interfaces/IERC5827Proxy.sol ./src/interfaces/IERC5827Spender.sol ./src/interfaces/IFunnel.sol ./src/interfaces/IFunnelFactory.sol ./src/lib/EIP712.sol ./src/lib/MetaTxContext.sol ./src/lib/NativeMetaTransaction.sol ./src/lib/Nonces.sol

Recommendation

Consider locking the pragma version whenever possible and avoid using a floating pragma in the final deployment.

Status

New