search

suberra / funnel-contracts

Funnels are smart contracts that enforces renewable allowance as a proxy
MIT License
9 stars 0 forks source link

[Hacken 2022-11-25 Low #2] Inconsistent Usage of External Libraries #37

Closed zhongfu closed 1 year ago

zhongfu commented 1 year ago

All contracts use OpenZeppelin external libraries heavily.

However, the Funnel contract imports the solmate ERC20 and SafeTransferLib libraries. This is inconsistent with overall external library usage.

Path

./src/Funnel.sol

Recommendation

Consider using only one external dependency - the IERC20 and SafeERC20 from OpenZeppelin.

Status

New