search

suberra / funnel-contracts

Funnels are smart contracts that enforces renewable allowance as a proxy
MIT License
9 stars 0 forks source link

[Hacken 2022-11-25 Low #10] Functions that Can Be Declared External #45

Closed zhongfu closed 1 year ago

zhongfu commented 1 year ago

In order to save Gas, public functions that are never called in the contract should be declared as external.

Paths

./src/Funnel.sol : initialize(), permit(), permitRenewable(), approve(), approveRenewable(), allowance(), renewableAllowance(), supportsInterface() ./src/FunnelFactory.sol : deployFunnelForToken(), isFunnel()

Recommendation

Use the external attribute for functions that are never called from the contract.

Status

New