suberra / funnel-contracts

Funnels are smart contracts that enforces renewable allowance as a proxy
MIT License
9 stars 0 forks source link

[Hacken 2022-12-21 Medium #05] Best Practice Violation - Lock of Native Tokens #74

Closed zlace0x closed 1 year ago

zlace0x commented 1 year ago

It is considered following best practices to avoid unclear situations and prevent common attack vectors.

The contract accepts native tokens in the executeMetaTransaction() payable function, but there are no mechanisms for withdrawals.

This may lead to native coins being locked in the contract.

Path: ./src/NativeMetaTransaction.sol : executeMetaTransaction()

Recommendation: Remove payable mutability modifier.

Status: New