suberra / funnel-contracts

Funnels are smart contracts that enforces renewable allowance as a proxy
MIT License
9 stars 0 forks source link

[Hacken 2022-12-21 Low #12] Unclear Use of the Virtual Specifier #77

Closed zlace0x closed 1 year ago

zlace0x commented 1 year ago

There are functions in the contracts that are declared with the virtual specifier. These functions are not expected to be overridden, so the use of the virtual specifier is redundant.

Path: ./src/Funnel.sol : computeDomainSeparator(), permit(), permitRenewable(), _checkOnTransferReceived(), _checkOnApprovalReceived(), supportsInterface(), _fallback()

Recommendation: Consider removing redundant code.

Status: Reported (There are still functions with redundant virtual specifier)