search

suberra / funnel-contracts

Funnels are smart contracts that enforces renewable allowance as a proxy
MIT License
9 stars 0 forks source link

[Hacken 2022-12-21 Low #17] Unindexed Events #78

Closed zlace0x closed 1 year ago

zlace0x commented 1 year ago

Having indexed event parameters makes it easier to search for these events using indexed event parameters as filters.

Path: ./src/lib/NativeMetaTransaction.sol : MetaTransactionExecuted()

Recommendation: The “indexed” keyword should be used for the event parameters.

Status: Reported (Consider also indexing relayerAddress)

zlace0x commented 1 year ago

This incur additional 200 gas to index address.