subframe7536 / vscode-theme-maple

Colorful VSCode theme in light / dark, medium brightness and saturation
https://marketplace.visualstudio.com/items?itemName=subframe7536.theme-maple
MIT License
33 stars 0 forks source link

Wrong `invalid.illegal.character-not-allowed-here.html` font style #1

Closed nandordudas closed 1 month ago

nandordudas commented 1 month ago

I'm using the Maple Theme and there is a non-expected token if I'm using self closing tags in HTML.

[!NOTE]

  • Windows 11 23H2 with WSL 2
  • VSCode: 1.93.1
  • Maple-Mono 6.4 (and ^7 too)
  • Extension: v0.4.5
  • ligature settings change has no effect

Code:

<template>
  <UContainer data-layout="default">
    <slot />
  </UContainer>
</template>

https://github.com/user-attachments/assets/282baf03-e431-4617-9c2d-2144e9f01fc3

nandordudas commented 1 month ago

I made fix with workspace settings:

{
  "editor.tokenColorCustomizations": {
    "[Maple Light][Maple Dark]": {
      "textMateRules": [
        {
          "scope": "invalid.illegal.character-not-allowed-here.html",
          "settings": {
            "fontStyle": ""
          }
        }
      ]
    }
  }
}

image

subframe7536 commented 1 month ago

Thanks for detailed issue, I will fix it later

nandordudas commented 1 month ago

No issue found. Thanks! 🤗 The Vs Code extension has been updated to v0.4.6.